Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support values lookup for range on mapping #86

Merged
merged 5 commits into from
May 24, 2024

Conversation

qvalentin
Copy link
Collaborator

@qvalentin qvalentin commented May 20, 2024

Before only ranges on lists were supported

TODO:

  • also support it for go-to-definition
  • test it in hover/completion etc. tests

Test for definition will be done later, as I started testing it in #80

@qvalentin qvalentin force-pushed the feature/values-loopup-for-range-on-mapping branch 4 times, most recently from b4a9aa1 to 6c2b248 Compare May 23, 2024 16:56
@qvalentin qvalentin force-pushed the feature/values-loopup-for-range-on-mapping branch from 6c2b248 to 62ca24c Compare May 24, 2024 17:29
@qvalentin qvalentin merged commit dac75a8 into master May 24, 2024
4 checks passed
Krismix1 added a commit to Krismix1/helm-ls that referenced this pull request May 26, 2024
* fork-master: (35 commits)
  Build only linux amd64
  Support list of glob patterns
  feat: support values lookup for range on mapping (mrjosh#86)
  feat(symbol-table): read in template context with variables (mrjosh#85)
  fix: prevent panic on empty or unsupported template context (mrjosh#83)
  feat: use helm as a libary instead of copying code (mrjosh#77)
  feat: completion for unfinished_selector_expression
  fix: update ts grammar
  feat(completion): tests and refactoring
  feat(hover): template context hover usecase
  feat: references for templateContext
  feat: add references
  feat(reference): symbol-tables provides definition references
  feat(symboltable): add symboltable
  feat(docs): add coc config and reword readme
  build(deps): bump golang.org/x/net from 0.19.0 to 0.23.0
  fix(handler): remove all unimplemented panics (mrjosh#73)
  fix(hover): format numbers correctly
  fix(hover): format list as yaml
  fix(go-to-definition): support range values
  ...
@qvalentin qvalentin deleted the feature/values-loopup-for-range-on-mapping branch July 21, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant